Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add vc_count to increase the number of validators per participant #633

Merged
merged 16 commits into from
May 28, 2024
Merged

feat: add vc_count to increase the number of validators per participant #633

merged 16 commits into from
May 28, 2024

Conversation

barnabasbusa
Copy link
Contributor

No description provided.

@barnabasbusa barnabasbusa linked an issue May 23, 2024 that may be closed by this pull request
Unexpected behavior when combining validator_count and count #628
Closed
@barnabasbusa barnabasbusa mentioned this pull request May 23, 2024
Closed
@0xTylerHolmes
Copy link
Contributor

Created #640 to fix some crashes I was having on this branch. Could you please review, there was one potential side-effect the PR may cause. Other than that it LGTM

@0xTylerHolmes @barnabasbusa
fix: Vc count logic (#640)
d31ed99 
I ran into a few index out of bounds and divide by zero issues. I fixed
those with what I expect is the right method. One thing I would like you
to check is my change on the
[participant_network.star](https://github.com/0xTylerHolmes/ethereum-package/blob/061dbec8694e78dfeb2cf9c48d351202866fd6e6/src/participant_network.star#L397)

I added a check on the `vc_context` assignment for the case where
`vc_count == 0`. We would get an index out of bounds panic so I just set
it to `None`. I'm unsure if there are downstream consequences but
everything appears to be working on my end with that.

---------

Co-authored-by: Barnabas Busa <busa.barnabas@gmail.com>
parithosh
parithosh reviewed May 28, 2024
View reviewed changes
README.md Show resolved Hide resolved
@barnabasbusa barnabasbusa merged commit 4272ff3 into main May 28, 2024
12 checks passed
@barnabasbusa barnabasbusa deleted the bbusa/vc_count branch May 28, 2024 15:09
@github-actions github-actions bot mentioned this pull request May 28, 2024
Merged
barnabasbusa pushed a commit that referenced this pull request Jun 10, 2024
@github-actions
chore(main): release 3.1.0 (#594)
20fef70 
🤖 I have created a release *beep* *boop*
---


##
[3.1.0](3.0.0...3.1.0)
(2024-06-07)


### Features

* add http url to el context
([#656](#656))
([4e69a4c](4e69a4c))
* add prefunded accounts to output
([#657](#657))
([bc06e2a](bc06e2a))
* add tracoor
([#651](#651))
([b100cb6](b100cb6))
* add vc_count to increase the number of validators per participant
([#633](#633))
([4272ff3](4272ff3))
* allow setting custom dora image & env variables
([#623](#623))
([08a65c3](08a65c3))
* **apache:** Serve all config files
([#606](#606))
([3f1f5e1](3f1f5e1))
* **config:** add peerdas vars
([#619](#619))
([22f1498](22f1498))
* expose network-params
([#659](#659))
([b0820dd](b0820dd))
* forky
([#625](#625))
([ded68bd](ded68bd))
* Support participants_matrix
([#620](#620))
([3a57467](3a57467))
* use `peer-das` image for dora when eip7594 is active
([#593](#593))
([1b4bd3d](1b4bd3d))


### Bug Fixes

* add additional prefund addresses
([#655](#655))
([6d2cdb6](6d2cdb6))
* add cl log level to builders
([#638](#638))
([ad46dbd](ad46dbd))
* Add EIP-7002 & EIP-2935 bytecode to ethereum-genesis-generator
([#597](#597))
([3d316ef](3d316ef))
* add http to teku endpoint
([#622](#622))
([085b6e1](085b6e1))
* add peer_das_epoch to egg
([#603](#603))
([91694df](91694df))
* add sha256 as an image label (if present)
([#637](#637))
([3dcf888](3dcf888))
* add static port config for apache
([#608](#608))
([b96e502](b96e502))
* **apache:** only set static port if wanted
([#610](#610))
([2c6b7b1](2c6b7b1))
* blockscout fix for json variant
([#662](#662))
([e79c510](e79c510))
* churn adjustments
([#614](#614))
([12ca872](12ca872))
* default config
([#632](#632))
([14be117](14be117))
* drop everythign after [@sha](https://github.com/sha) from image labels
([#636](#636))
([5d35463](5d35463))
* erigon v3 - new default image
([#629](#629))
([72cf150](72cf150))
* genesis generator bump
([#611](#611))
([5460f6f](5460f6f))
* nightly tests
([#595](#595))
([76c31e9](76c31e9))
* pectra example
([#605](#605))
([67e3da0](67e3da0))
* prysm vc key manager ports
([#639](#639))
([81c1ee7](81c1ee7))
* re-add images to labels
([#634](#634))
([71f6e28](71f6e28))
* README has invalid configs
([#631](#631))
([e33b971](e33b971))
* readme indentation
([#600](#600))
([583db1b](583db1b))
* registration flags when using beacon node only
([#618](#618))
([c12506b](c12506b))
* repair check workflow for external PRs
([#616](#616))
([a584682](a584682))
* seperate vc service names
([#654](#654))
([a5ffe14](a5ffe14))
* tune Besu options to work with tx_spammer
([#612](#612))
([b395189](b395189))
* update dora images
([#598](#598))
([dd28d61](dd28d61))
* update prysm image
([#599](#599))
([0a38114](0a38114))
* use `electra-support` image for assertoor when electra fork epoch is
set
([#607](#607))
([cdeab93](cdeab93))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parithosh parithosh parithosh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected behavior when combining validator_count and count
3 participants
@barnabasbusa @0xTylerHolmes @parithosh