Handle inbox error #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: handle failure when derive
qizhou
reviewed
Apr 6, 2024
| } | ||
|
|
||
| // only set GasLimit when inbox is EOA so that later on `EstimateGas` will be called | ||
| if *l.inboxIsEOA { |
There was a problem hiding this comment.
When inboxIsEOA, what is the GasLimit of the batchTx?
There was a problem hiding this comment.
core.IntrinsicGas(candidate.TxData, nil, false, true, true, false), the same as the GasLimit before this change.
There was a problem hiding this comment.
It will be set later here by EstimateGas.
qizhou
approved these changes
Apr 8, 2024
qzhodl
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When submiting, as
eth-clientis readily available so we check whetherbatchInboxAddrisEOA. If it'sEOAthen nothing is changed. Otherwise theGasLimitis unset so later onestimate_gaswill be called to check for possible error.When deriving, in theory, we only need to check receipt status if
batchInboxAddris a contract.But the api provided by
L1Fetcheris quite limited(noCodeAtapi) as it's also called byop-programe.It doesn't seem worth it to add another key type to the hint/oracle just to save a call to
FetchReceipts, and it's only called once every L1 block, so should not impact performance too much in general.