New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Database parameters #3450
Merged
Merged
Database parameters #3450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
ewdurbin
force-pushed
the
datbase_parameters
branch
from
June 5, 2023 00:16
83a80ba
to
817ce12
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3450 +/- ##
==========================================
- Coverage 87.14% 87.13% -0.01%
==========================================
Files 312 312
Lines 18761 18774 +13
Branches 2390 2392 +2
==========================================
+ Hits 16349 16359 +10
- Misses 1988 1991 +3
Partials 424 424
☔ View full report in Codecov by Sentry. |
ThomasLaPiana
approved these changes
Jun 7, 2023
@RobertKeyser want to try using these now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1791
Code Changes
Steps to Confirm
sslmode
orsslrootcert
and note that they are associated with the URIs and if your database doesn't support TLS (like in dev/test) things go 💥Pre-Merge Checklist
CHANGELOG.md
Description Of Changes
This implements the ability for users to configure database connection parameters to support things like TLS connections with full validation.
I chose the most direct and flexible option in issue #1791, as tweaking these means a user generally knows what they want very specifically.