Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDB Timeout Error #5091

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SteveDMurphy
Copy link
Contributor

Closes FIDES-1018

Description Of Changes

The MongoDB Integration is hitting a timeout error on certain deployed instances.

This bumps the current setting from 5 to a higher default.

Optionally, we may make this configurable (with a sane default)

Code Changes

  • Bump timeout from 5 seconds to 60

Steps to Confirm

  • Testing when deployed on image

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 9:57pm

Copy link

cypress bot commented Jul 17, 2024

Passing run #8984 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge effe054 into 51d7b88...
Project: fides Commit: 3436a16410 ℹ️
Status: Passed Duration: 00:38 💡
Started: Jul 17, 2024 10:05 PM Ended: Jul 17, 2024 10:05 PM

Review all test suite changes for PR #5091 ↗︎

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.51%. Comparing base (51d7b88) to head (effe054).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5091   +/-   ##
=======================================
  Coverage   86.51%   86.51%           
=======================================
  Files         357      357           
  Lines       22310    22310           
  Branches     2947     2947           
=======================================
  Hits        19301    19301           
  Misses       2495     2495           
  Partials      514      514           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant