This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Refactor static checks to run outside of Docker #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasLaPiana
commented
Aug 9, 2022
| @@ -14,3 +14,4 @@ | |||
|
|
|||
| # Sets the default session to `--list` | |||
| nox.options.sessions = [] | |||
| nox.options.reuse_existing_virtualenvs = True | |||
There was a problem hiding this comment.
without reusing the virtual envs the runs take much longer, and the first run will also take much longer as it installs and caches it.
This still catches whenever a package version changes, so no downsides here
….com/ethyca/fidesops into ThomasLaPiana-refactor-static-checks
|
execution time on the static checks with the new method is 1-2 minutes, much faster than the previous iteration |
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Refactor static checks to run outside of Docker * run static checks outside of docker, reusing cached virtual envs * update the changelog * Create CHANGELOG.md * Update CHANGELOG.md * update the static checks in the workflows * remove the static check dependency on "build"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Run the static code checks outside of Docker
Changes
Checklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.If docs updated (select one):Good unit test/integration test coverageThis PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before mergingTheRun Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #990