Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

983 Adds infra for email config and dispatch #1059

Merged
merged 15 commits into from
Aug 17, 2022

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Aug 10, 2022

Purpose

Prove we can store email configs and send dummy MFA email using mailgun (actually implements much of the work needed for CRUD/db layer for email config)

Changes

  • Adds APIs for email config
  • Adds db migration
  • Adds associated db models, schemas, and enums
  • Adds to postman collection

Follow-ups / associated tickets:

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #983

@eastandwestwind eastandwestwind changed the title WIP 983 email config MVP WIP 983 email config POC Aug 10, 2022
@eastandwestwind eastandwestwind changed the title WIP 983 email config POC 983 Adds infra for email config and dispatch Aug 15, 2022
"""Enum for email service details"""

# mailgun-specific
IS_EU_DOMAIN = "is_eu_domain"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does EmailServiceDetails need IS_SERVICE_DETAILS when EmailServiceDetailsMailgun has is_eu_domain?

Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Great job at making it modular. It should be straight forward to add more email providers in the future.

@TheAndrewJackson TheAndrewJackson merged commit 367613f into main Aug 17, 2022
@TheAndrewJackson TheAndrewJackson deleted the 983-email-config-mvp branch August 17, 2022 17:00
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
* Email config mvp crud / db layer

* adds name to email config model

* remove unintended changes

* gets POC working

* removes org name config var, updates crud endpoints to better handle supporting only 1 config, formatting

* updates postman collection, adds to changelog, bumps downrev on migration

* sort

* formatting

* use correct response model

* Delete base.py

* update migration annotation
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Spike] Email server options (Timebox: 1 week)
3 participants