This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Add Sass connector configuration #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
761 - Add a Connection - SaaS connector's configuration parameters 984 - Saas Connector configuration - left navigation to toggle between connection params and dataset config 985 - SaaS Connector Configuration - Testing a Connection
By default, turning off the createNewConnection flag which is still under development.
chriscalhoun1974
changed the title
seanpreston
reviewed
Aug 18, 2022
.../ops/admin-ui/src/features/datastore-connections/add-connection/sass/ConnectorParameters.tsx
Outdated
Show resolved
Hide resolved
seanpreston
reviewed
Aug 18, 2022
| useEffect(() => { | ||
| updateCachedFilters.current(filters); | ||
| }, [setCachedFilters, filters]); | ||
|
|
||
| const { data, isFetching, isLoading, isSuccess } = | ||
| useGetAllConnectionTypesQuery(cachedFilters); | ||
|
|
||
| const handleSearchChange = (event: React.ChangeEvent<HTMLInputElement>) => |
There was a problem hiding this comment.
Should we add some constraints here, like debouncing or a minimum search term length before we send anything off to the API?
There was a problem hiding this comment.
There is a debounce on line 35. I do agree maybe we increase the milliseconds from 250 to 500 and have a minimum character limit of 2. Your thoughts?
There was a problem hiding this comment.
Have added this to a follow-up
seanpreston
reviewed
Aug 18, 2022
.../ops/admin-ui/src/features/datastore-connections/add-connection/sass/ConnectorParameters.tsx
Show resolved
Hide resolved
seanpreston
reviewed
Aug 18, 2022
seanpreston
reviewed
Aug 18, 2022
seanpreston
approved these changes
Aug 22, 2022
There was a problem hiding this comment.
Thanks for the hard work here @chriscalhoun1974, in testing this I've logged the following issues but none are blockers:
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Sass Connecter feature development 761 - Add a Connection - SaaS connector's configuration parameters 984 - Saas Connector configuration - left navigation to toggle between connection params and dataset config 985 - SaaS Connector Configuration - Testing a Connection * Skipping unit test temporarily * Update flags.json file By default, turning off the createNewConnection flag which is still under development. * Updated CHANGELOG.md file * Resolved ESLint issues * Resolved npm build issue * Resolved npm build issue * Updated Saas connector configuration * Updated Saas connector configuration * Removed unnecessary import statement * add new privilege for creating SaaS connectors to user management interface * add connections read as a privilege * Applied code review feedback * Updated the CSS visibility of the CircleHelpIcon component * Added toast success when a user creates a Saas config * Resolved ESLint issue Co-authored-by: Sean Preston <sean@ethyca.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When a user clicks the "Create New Connection" button, display a series of screens which allow the user to select a given Sass connector and configure connector configuration info.
Changes
Checklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #761 #984 #985