Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Add email_templates module #1123

Merged
merged 22 commits into from
Aug 23, 2022
Merged

Add email_templates module #1123

merged 22 commits into from
Aug 23, 2022

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Aug 22, 2022 •
edited
Loading

Purpose

Update email code to use templates

Changes

  • Use templates for emails instead of hardcoded message
  • Rename access_code to verification_code to match other area in the codebase

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1061

@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review August 22, 2022 20:56
@sanders41 sanders41 merged commit 62441f8 into main Aug 23, 2022
@sanders41 sanders41 deleted the 1061_email_templates branch August 23, 2022 15:56
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
@TheAndrewJackson
Add email_templates module (#1123)
b0eee6d 
* Add email_templates module

* run isort

* Add unit tests

* Update ttl calculation

* Add ttl minutes test

* fix lint issues

* fix pylint issue

* fix pylint issue

* fix isort

* Update template constant

* Update changelog

* fix lints

* Add jinja to requirements.txt

* update templates directory

* update unit test

* Update imports

* fix issue template path

* Add templates to manifest

Co-authored-by: Paul Sanders <pau@ethyca.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sanders41 sanders41 sanders41 approved these changes

Assignees

@sanders41 sanders41

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement templates for email service
2 participants
@TheAndrewJackson @sanders41