Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Fix docs build in CI #1138

Merged
merged 3 commits into from
Aug 24, 2022
Merged

Fix docs build in CI #1138

merged 3 commits into from
Aug 24, 2022

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Aug 23, 2022

Purpose

Fix the issue with docs building in CI

Changes

  • Change docs build from make to nox

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1137

@seanpreston seanpreston merged commit 5f7b046 into main Aug 24, 2022
@seanpreston seanpreston deleted the docs branch August 24, 2022 21:30
@pattisdr
Copy link
Contributor

thanks for reviewing and merging for me @seanpreston

sanders41 added a commit that referenced this pull request Sep 22, 2022
* Fix docs build in CI

* Update CHANGELOG

Co-authored-by: Paul Sanders <pau@ethyca.com>
Co-authored-by: Sean Preston <sean@ethyca.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs build in CI still using make instead of nox
3 participants