Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

SaaS Connector Template Creation Fix: Integer fides_key #1166

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Aug 26, 2022

Purpose

Screen Shot 2022-08-26 at 11 27 22 AM

We want to have the same identifier used across a saas config and dataset config but integer keys were not accounted for.
Spotted by @chriscalhoun1974 - he created a saas connection config from a template in testing and gave it an "instance_fides_key" of "111". This is saved as a string type on the DatasetConfig.fides_key but is interpreted as an integer when parsing the yaml. This throws a validation error later when you try to edit the dataset, and we see that the datasetconfig.fides_key field does not match the fides_key in the saas config.

Changes

  • Use quotes to force a string when replacing <"instance_fides_key"> in the saas config and dataset config yaml.

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Unticketed

@pattisdr pattisdr added the bug Something isn't working label Aug 26, 2022
@pattisdr pattisdr marked this pull request as ready for review August 26, 2022 16:35
@sanders41 sanders41 merged commit 19fbe93 into main Aug 26, 2022
@sanders41 sanders41 deleted the saas_connector_template_integer_fix branch August 26, 2022 17:32
seanpreston added a commit that referenced this pull request Aug 26, 2022
pattisdr pushed a commit that referenced this pull request Aug 26, 2022
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
* Use quotes when replacing <"instance_fides_key"> in the saas config and dataset config files to force a string.

* Update CHANGELOG.
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants