Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Adds email communications guide to docs, exposes other hidden guides in nav bar #1233

Merged
merged 5 commits into from
Aug 31, 2022

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Aug 31, 2022

Purpose

Adds guide on email communications and setting up an email config/secrets to docs.

Also exposes previously hidden guides in the docs nav bar.

Changes

  • Update docs

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1064

@eastandwestwind
Copy link
Contributor Author

screencapture-0-0-0-0-8000-fidesops-guides-email-communications-2022-08-31-11_29_30

docs/fidesops/mkdocs.yml Outdated Show resolved Hide resolved
docs/fidesops/mkdocs.yml Outdated Show resolved Hide resolved
@conceptualshark
Copy link
Contributor

I took a quick pass at cleaning some of this up to match some of the updated/incoming guides - let me know if it's what you had in mind!

@eastandwestwind
Copy link
Contributor Author

@conceptualshark your updates look so much better, thanks for the help on this!

Back over to you

@conceptualshark conceptualshark merged commit 6e9ba83 into main Aug 31, 2022
@conceptualshark conceptualshark deleted the 1064-email-config-docs branch August 31, 2022 19:34
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
…in nav bar (#1233)

* adds email communications guide to docs, exposes other hidden guides in nav bar

* update changelog

* email docs copyedits

* remove dupe items from nav

Co-authored-by: Cole <cole@ethyca.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docs for email config
2 participants