This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Braze Connector: Access Endpoints #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sadaqatullah
force-pushed
the
322-braze
branch
from
050f60f
to
28f3e8f
Compare
sadaqatullah
changed the title
* Added Erasure Endpoints. * Test Cases * Finalized yml Files * Finalized tests and fixtures * Black Fix
galvana
reviewed
Sep 28, 2022
CHANGELOG.md
Outdated
| @@ -78,6 +78,7 @@ The types of changes are: | |||
| * Frontend - Configure a Manual entry connector [#1015](https://github.com/ethyca/fidesops/pull/1247) | |||
| * Manual webhook test functionality [#1323](https://github.com/ethyca/fidesops/pull/1323/) | |||
| * Added change request table [#1340](https://github.com/ethyca/fidesops/pull/1340) | |||
| * Adds Access Endpoints for Braze [#1248](https://github.com/ethyca/fidesops/pull/1248) | |||
There was a problem hiding this comment.
Changed to Access and erasure support for Braze and moved it to the Unreleased section.
galvana
reviewed
Sep 28, 2022
data/saas/config/braze_config.yml
Outdated
| test_request: | ||
| method: GET | ||
| path: /email/hard_bounces/ | ||
| headers: |
There was a problem hiding this comment.
The test request will use the same auth as the client_config so there is no need to specify the headers here. Also, you can just use the <api_key> placeholder here without having to use a param_value (I know this last one is a bit weird).
galvana
reviewed
Sep 28, 2022
| - fides_key: <instance_fides_key> | ||
| name: Braze Dataset | ||
| description: A sample dataset representing the Braze connector for Fidesops | ||
| collections: |
There was a problem hiding this comment.
Good work tagging the fields with the appropriate data categories 👍
galvana
added
run unsafe ci checks
galvana
approved these changes
Sep 28, 2022
galvana
added
run unsafe ci checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Implements Braze PII endpoints.
Checklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #322