Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Fix download link #1264

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Fix download link #1264

merged 2 commits into from
Sep 7, 2022

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Sep 7, 2022

Purpose

Fix the bad response for server message. BASE_API_URN contains api/v1, but not the base of the URL so the resulting URL was defaulting to the web server URL: http://localhost:3000... instead of http://localhost:8080...

Changes

  • Changed BASE_API_URN to BASE_URL

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1263

@sanders41 sanders41 marked this pull request as ready for review September 7, 2022 00:35
@TheAndrewJackson TheAndrewJackson merged commit 06945bd into main Sep 7, 2022
@TheAndrewJackson TheAndrewJackson deleted the ps-admin-download branch September 7, 2022 15:11
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
* Fix download link

* Update changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FidesOps says "Bad Response from Server" on download
2 participants