Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

1155 email upon privacy request review #1306

Merged
merged 16 commits into from
Sep 15, 2022

Conversation

eastandwestwind
Copy link
Contributor

@eastandwestwind eastandwestwind commented Sep 13, 2022

Allows sending email upon privacy request review, including denial reason if applicable

Changes

  • Adds template for privacy request review
  • Adds new config var FIDESOPS__NOTIFICATIONS__SEND_REQUEST_REVIEW_NOTIFICATION
  • Adds logic in privacy request endpoint to handle email send, if applicable
  • Updates docs

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1155

Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good attention to detail here @eastandwestwind on this and your related PR today. Just a few comments.

@pattisdr pattisdr self-assigned this Sep 14, 2022
@eastandwestwind
Copy link
Contributor Author

@pattisdr ready for you again, thanks for the review!

Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@pattisdr pattisdr merged commit 504d7ca into main Sep 15, 2022
@pattisdr pattisdr deleted the 1155-email-upon-privacy-request-review branch September 15, 2022 18:47
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email notification acknowledging PrivacyRequest review
4 participants