Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Rename PrivacyRequestIdentity schema to Identity #1324

Merged
merged 2 commits into from
Sep 15, 2022
Merged

Rename PrivacyRequestIdentity schema to Identity #1324

merged 2 commits into from
Sep 15, 2022

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Sep 14, 2022 •
edited

Purpose

I plan to use the PrivacyRequestIdentity schema in the consent request workflow. In preparation for that I am renaming it to Identity to give a more generic name.

Changes

  • Rename PrivacyRequestIdentity to Identity

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #

@sanders41 sanders41 added the run unsafe ci checks Triggers running of unsafe CI checks label Sep 14, 2022
@seanpreston seanpreston self-assigned this Sep 15, 2022
@seanpreston seanpreston merged commit 2f678b1 into main Sep 15, 2022
@seanpreston seanpreston deleted the ps-identity-schema branch September 15, 2022 16:31
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
Rename PrivacyRequestIdentity schema to Identity (#1324)
95a73a5 
* Rename PrivacyRequestIdentity schema to Identity

* Update changelog

Co-authored-by: Paul Sanders <pau@ethyca.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@seanpreston seanpreston seanpreston approved these changes

Assignees

@seanpreston seanpreston

Labels
run unsafe ci checks Triggers running of unsafe CI checks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sanders41 @seanpreston