Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Fixing Stripe Tests #1352

Merged
merged 2 commits into from
Sep 20, 2022
Merged

Fixing Stripe Tests #1352

merged 2 commits into from
Sep 20, 2022

Conversation

galvana
Copy link
Collaborator

@galvana galvana commented Sep 19, 2022

Purpose

To resolve the issues caused by running multiple instances of the Stripe tests simultaneously

Changes

  • Updating assertions in access test
  • Using randomly generated email for erasure test
  • Added connection test

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1351

@galvana galvana linked an issue Sep 19, 2022 that may be closed by this pull request
@galvana galvana added the run unsafe ci checks Triggers running of unsafe CI checks label Sep 19, 2022
@galvana galvana added run unsafe ci checks Triggers running of unsafe CI checks and removed run unsafe ci checks Triggers running of unsafe CI checks labels Sep 20, 2022
Copy link
Contributor

@seanpreston seanpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for hopping on and fixing this @galvana. In the course of running the SaaS tests I've seen both Shopify and Hubspot fail only intermittently, so will go ahead and merge.

@seanpreston seanpreston merged commit d5ba72d into main Sep 20, 2022
@seanpreston seanpreston deleted the 1351-fix-stripe-tests branch September 20, 2022 03:28
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
* Updating assertions and using a unique erasure identity email per test run

* Fixing sort order
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
run unsafe ci checks Triggers running of unsafe CI checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Stripe tests
2 participants