Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Add new template for consent requets emails #1405

Merged
merged 3 commits into from
Sep 28, 2022
Merged

Add new template for consent requets emails #1405

merged 3 commits into from
Sep 28, 2022

Conversation

sanders41
Copy link
Contributor

Purpose

Adds a new email template for consent request verification codes.

Changes

  • Add CONSENT_REQUEST as an email type
  • Adds a template for consent request emails
  • Uses separate email templates for consent requests and privacy requests.

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #1400

TheAndrewJackson
TheAndrewJackson suggested changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nit otherwise looks great and should be ready after that.

src/fidesops/ops/service/email/email_dispatch_service.py Outdated
if action_type == EmailActionType.CONSENT_REQUEST:
template = get_email_template(action_type)
return EmailForActionType(
subject="your one-time code",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nit

Suggested change
subject="your one-time code",
subject="Your one-time code",

@TheAndrewJackson TheAndrewJackson self-assigned this Sep 28, 2022
@sanders41
Copy link
Contributor Author

The test failures look unrelated to me, they passed locally. Running again to see if they still fail.

@TheAndrewJackson TheAndrewJackson merged commit 6879403 into main Sep 28, 2022
@TheAndrewJackson TheAndrewJackson deleted the ps-consent-request-email-template branch September 28, 2022 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TheAndrewJackson TheAndrewJackson TheAndrewJackson approved these changes

Assignees

@TheAndrewJackson TheAndrewJackson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new email template for consent request
2 participants
@sanders41 @TheAndrewJackson