Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Add Braze connector registry entry #1418

Merged
merged 4 commits into from
Oct 3, 2022
Merged

Add Braze connector registry entry #1418

merged 4 commits into from
Oct 3, 2022

Conversation

sadaqatullah
Copy link
Contributor

@sadaqatullah sadaqatullah commented Oct 3, 2022

Purpose

Adds entry for Braze to the connector registry

Changes

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #
#1419

@sadaqatullah sadaqatullah self-assigned this Oct 3, 2022
@sadaqatullah sadaqatullah force-pushed the braze-svg branch 2 times, most recently from 8ce95d5 to bbd4c7b Compare October 3, 2022 15:06
@adamsachs adamsachs changed the title Braze SVG added Add Braze connector registry entry Oct 3, 2022
@sadaqatullah sadaqatullah force-pushed the braze-svg branch 3 times, most recently from b1e2d3c to 76ce8ea Compare October 3, 2022 15:28
Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good, if/when tests pass i think we're good to go. thanks for patching this up quickly @sadaqatullah !

@adamsachs adamsachs merged commit b42e6d7 into main Oct 3, 2022
@adamsachs adamsachs deleted the braze-svg branch October 3, 2022 16:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants