Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

DX Improvements from v1.8.1 release #1421

Merged
merged 5 commits into from
Oct 4, 2022
Merged

DX Improvements from v1.8.1 release #1421

merged 5 commits into from
Oct 4, 2022

Conversation

seanpreston
Copy link
Contributor

@seanpreston seanpreston commented Oct 3, 2022 •
edited

Purpose

This PR improves the DX in the following ways:

  • better reporting of errors when DatasetConfig get_or_create_dataset is attempted, to log the IntegrityError that's thrown by SQLAlchemy when a DatasetConfig already exists, and it belongs to a different ConnectionConfig to the one specified in the data.
  • don't attach the analytics middleware if the user has opted out via the config — this saves a lot of unnecessary logging output during development

@seanpreston seanpreston marked this pull request as ready for review October 4, 2022 01:13
NevilleS
NevilleS approved these changes Oct 4, 2022
View reviewed changes
Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Merge away

@seanpreston seanpreston merged commit da6fe5f into main Oct 4, 2022
@seanpreston seanpreston deleted the hotfix/dataset-upload branch October 4, 2022 01:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@NevilleS NevilleS NevilleS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seanpreston @NevilleS