This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Revoke a Pending Privacy Request [#525] #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ethyca/docs-authors small addition to drp docs added here |
…ally cancelled yet. - Track cancel reason, datetime cancelled, and add a new cancelled status.
pattisdr
force-pushed
the
fidesops_525_cancel_a_request
branch
from
25c6702
to
c442245
Compare
pattisdr
changed the title
# Conflicts: # clients/admin-ui/src/features/privacy-requests/RequestBadge.tsx
…execution. This is really our last chance to check before we start executing the graph in dask. The use case here might be it was canceled shortly after it was approved.
pattisdr
changed the title
…_request # Conflicts: # CHANGELOG.md
seanpreston
reviewed
Jun 23, 2022
…sk with a cancelled task id doesn't do anything and how you can't approve a canceled privacy request.
…o the rest of the application.
pattisdr
commented
Jun 23, 2022
seanpreston
reviewed
Jun 23, 2022
seanpreston
reviewed
Jun 23, 2022
seanpreston
reviewed
Jun 23, 2022
seanpreston
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Thanks @pattisdr — couple of optional changes to follow-up here or we can ticket them and ship 1.6.0
|
I'll take care of them now thanks @seanpreston |
seanpreston
reviewed
Jun 23, 2022
…_request # Conflicts: # docs/fidesops/docs/postman/Fidesops.postman_collection.json
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* Add the ability to cancel a pending task. The celery task is not actually cancelled yet. - Track cancel reason, datetime cancelled, and add a new cancelled status. * Add drp revoke request to postman collection. * Add drp revoke docs. * Update down_rev after rebase. * Fix incorrect check. * Restore new canceled state. * Check that the privacy request is not canceled right before starting execution. This is really our last chance to check before we start executing the graph in dask. The use case here might be it was canceled shortly after it was approved. * Attempt to revoke a queued celery task if we cancel it before it starts executing. * Prettier. * Changelog updated. * Add a few unit tests around how triggering the run_privacy_request_task with a cancelled task id doesn't do anything and how you can't approve a canceled privacy request. * Fix SQLAlchemy logging to console - logging in migration propagates to the rest of the application. * Refresh session instead of creating a new one. * Add 200 character limit. * Add some assertions that db.refresh is doing what we think it's doing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Contains a migration; verify downrev before merging
Purpose
Add the ability to cancel a privacy request that has not started processing.
Changes
/api/v1/drp/revoke{ "request_id": "pri_fc899dd5-36fc-4cee-a1e3-39a5857c1a4c", "reason": "Accidentally submitted" }canceledrequest statusChecklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #418
Fixes #525