Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Match mypy settings to new migrations folder location #634

Merged
merged 2 commits into from
Jun 10, 2022
Merged

Match mypy settings to new migrations folder location #634

merged 2 commits into from
Jun 10, 2022

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Jun 10, 2022 •
edited by pattisdr

Purpose

MyPy is set to ignore the migrations folder, now that this folder has been moved the path in the mypy settings no longer matches the path.

Changes

  • Match the exclude path in pyproject.toml to the new path of the migrations.

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #633

@pattisdr pattisdr self-assigned this Jun 10, 2022
pattisdr
pattisdr approved these changes Jun 10, 2022
View reviewed changes
Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for jumping on this @sanders41

@pattisdr pattisdr merged commit ea71b09 into main Jun 10, 2022
@pattisdr pattisdr deleted the mypy-settings branch June 10, 2022 21:21
sanders41 added a commit that referenced this pull request Sep 22, 2022
@sanders41
Match mypy settings to new migrations folder location (#634)
1800bdb 
* Match mypy settings to new migrations folder location

* Update CHANGELOG

Co-authored-by: Paul Sanders <pau@ethyca.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pattisdr pattisdr pattisdr approved these changes

Assignees

@pattisdr pattisdr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MyPy settings need updating for the new migrations folder location
2 participants
@sanders41 @pattisdr