This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
Fixing connector integration tests #636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pattisdr
reviewed
Jun 10, 2022
| @@ -14,6 +14,7 @@ | |||
| from tests.graph.graph_test_util import assert_rows_match | |||
|
|
|||
|
|
|||
| @pytest.mark.skip(reason="Pending account resolution") | |||
galvana
added
run unsafe ci checks
pattisdr
approved these changes
Jun 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
There were a few connector integration tests failing on main. Some were resolved by re-creating the necessary test data (Stripe, Segment) but we still need access to a premium account to fully test Sentry.
The long term fix is to include the data creation for the access requests in the fixtures, but that will be covered in a separate ticket. The goal of this ticket is to get the tests passing again in main.
Changes
Checklist
Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external services