Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Only push to Dockerhub on releases #640

Merged
merged 1 commit into from
Jun 13, 2022

Conversation

ThomasLaPiana
Copy link
Contributor

@ThomasLaPiana ThomasLaPiana commented Jun 13, 2022

Purpose

Match fidesctl in only pushing releases to dockerhub when there is a release

Example here

Changes

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #

@seanpreston
Copy link
Contributor

Thankyou @ThomasLaPiana

@seanpreston seanpreston merged commit e65b245 into main Jun 13, 2022
@seanpreston seanpreston deleted the ThomasLaPiana-only-push-docker-on-release branch June 13, 2022 16:47
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants