Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Sort ConnectionConfig Name Ascending [#668] #672

Merged
merged 2 commits into from
Jun 16, 2022

Conversation

pattisdr
Copy link
Contributor

@pattisdr pattisdr commented Jun 16, 2022

Purpose

Support ordering datastores in the frontend.

Changes

  • Change sort order of GET /connection to be name ascending instead of created_at descending.

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #668

@pattisdr pattisdr marked this pull request as ready for review June 16, 2022 20:40
@seanpreston
Copy link
Contributor

This LGTM for this spec, thanks for the quick work @pattisdr.

@seanpreston seanpreston merged commit 4e8f0a1 into main Jun 16, 2022
@seanpreston seanpreston deleted the fidesops_668_sort_connections_name_ascending branch June 16, 2022 20:55
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
* Sort by connection name ascending.

* Update changelog.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Datastore Management] Sort datastore connection name is ascending order
2 participants