This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
update domain -> host config references in stripe and sentry test infrastructure #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for hopping on this @adamsachs + @galvana 🙏 |
galvana
added
run unsafe ci checks
galvana
reviewed
Jun 23, 2022
| @@ -54,6 +54,6 @@ identity_email = "" | |||
|
|
|||
| [zendesk] | |||
There was a problem hiding this comment.
Fixing names here, not necessary for our build pipeline but this needs to match if you're testing locally.
galvana
reviewed
Jun 23, 2022
| @@ -27,7 +27,7 @@ def test_saas_access_request_task( | |||
| """Full access request based on the Hubspot SaaS config""" | |||
|
|
|||
| privacy_request = PrivacyRequest( | |||
| id=f"test_saas_access_request_task_{random.randint(0, 1000)}" | |||
| id=f"test_hubspot_access_request_task_{random.randint(0, 1000)}" | |||
There was a problem hiding this comment.
To uniquely identify the test
galvana
reviewed
Jun 23, 2022
| f"Operational Error connecting to '{mailchimp_connection_config.key}'." | ||
| == body["failure_reason"] | ||
| f"Operational Error connecting to '{mailchimp_connection_config.key}'" | ||
| in body["failure_reason"] |
There was a problem hiding this comment.
Changed from a == to in since dev mode will cause the error to contain additional context.
galvana
reviewed
Jun 23, 2022
| @@ -1241,10 +1241,9 @@ def test_saas_connection_connect_with_components( | |||
| db: Session, | |||
| generate_auth_header, | |||
| mailchimp_connection_config, | |||
| mailchimp_secrets, | |||
There was a problem hiding this comment.
Removed this to prevent the secrets from being output to the logs during an error.
galvana
reviewed
Jun 23, 2022
| f"Operational Error connecting to '{mailchimp_connection_config.key}'." | ||
| == body["failure_reason"] | ||
| f"Operational Error connecting to '{mailchimp_connection_config.key}'" | ||
| in body["failure_reason"] |
galvana
added
run unsafe ci checks
galvana
approved these changes
Jun 23, 2022
There was a problem hiding this comment.
Thanks @adamsachs for starting this off, not sure if I should be approving this since I wrote part of it too but it's just a handful of simple changes.
galvana
deleted the
697-update-broken-references-in-integration-tests-to-outdated-host-secrets-param
branch
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
…rastructure (#698) Co-authored-by: Adam Sachs <adam@Adams-MacBook-Pro.local> Co-authored-by: Adrian Galvan <adriang430@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.