Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Make reading of environment variables case insensitive #712

Merged
merged 2 commits into from
Jun 27, 2022
Merged

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Jun 24, 2022

Purpose

Makes the reading of the boolean environment variables case insensitive

Changes

  • Convert the reading of the boolean environment in config.py to lower
  • Convert the reading of the boolean environment variable in logger.py to lower

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #710

@sanders41 sanders41 marked this pull request as ready for review June 24, 2022 15:00
@seanpreston seanpreston merged commit bd5f8c6 into main Jun 27, 2022
@seanpreston seanpreston deleted the env-vars branch June 27, 2022 17:57
sanders41 added a commit that referenced this pull request Sep 22, 2022
* Make reading of environment variables case insensitive

* Update CHANGELOG

Co-authored-by: Paul Sanders <pau@ethyca.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LOG_PII and DEV_MODE require case sensitive values
3 participants