-
Notifications
You must be signed in to change notification settings - Fork 16
706 Adds SaaS connection type to SaaS yaml config #748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice job in trying to find a workable solution for everyone @eastandwestwind, just a few minor things here.
@pattisdr I've been struggling with a CI error during
E.g. https://github.com/ethyca/fidesops/runs/7206676793?check_suite_focus=true I've been testing out some theories, but let me know if you've seen this before |
…, update previous schema migrations that used "alter type" to update connection type to rename the enum type, create a new enum with the new types, and then delete the old enum type. - Update the data migration to update the connection config > saas config field instead of the dataset config field.
Unit tests were failing because we were using I've updated older migrations to not use
|
…into 706-datastore-type-saas
@pattisdr I've just pushed out the changelog update (looks like some other recent PRs have been added to the 1.6.1 section also 😢 ). Otherwise, your changes look good, thanks so much for helping me out with this! |
@@ -19,6 +19,10 @@ The types of changes are: | |||
|
|||
## [Unreleased](https://github.com/ethyca/fidesops/compare/1.6.1...main) | |||
|
|||
### Added | |||
* Adds SaaS connection type to SaaS yaml config [748](https://github.com/ethyca/fidesops/pull/748) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is updated with main? the changelog there has more items in unreleased?
https://github.com/ethyca/fidesops/blob/c5c30840d07d2c2c4b999bdf241044690c63d092/CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
weirdddd lemme try again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, this looks better now
* Adds Saas type to saas yaml config * To allow data migration that queries on a connectiontype enum to work, update previous schema migrations that used "alter type" to update connection type to rename the enum type, create a new enum with the new types, and then delete the old enum type. Co-authored-by: Dawn Pattison <pattisdr@users.noreply.github.com>
Purpose
Adds SaaS connection type to SaaS yaml config
Changes
Checklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #706