Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Password Hashing update #749

Merged
merged 5 commits into from
Jun 29, 2022
Merged

Password Hashing update #749

merged 5 commits into from
Jun 29, 2022

Conversation

TheAndrewJackson
Copy link
Contributor

@TheAndrewJackson TheAndrewJackson commented Jun 28, 2022

Purpose

Update frontend to send base64 hashed password to backend

Changes

  • base64 encode password on frontend
  • update backend to decode incoming base64 back into plaintext & fix all backend test failures
  • add more tests for cryptographic_utils

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #

@TheAndrewJackson TheAndrewJackson changed the title Hashing update Password Hashing update Jun 28, 2022
@TheAndrewJackson TheAndrewJackson marked this pull request as ready for review June 28, 2022 17:29
Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement @TheAndrewJackson. The "Managing Users from the API" docs could also be updated here https://ethyca.github.io/fidesops/ui/user_management/#managing-users-from-the-api

@TheAndrewJackson
Copy link
Contributor Author

Thanks for taking a look @pattisdr and good find. I'll work on updating those docs now

Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me @TheAndrewJackson given the objectives we decided on for this one.

@pattisdr pattisdr merged commit 0586b4b into main Jun 29, 2022
@pattisdr pattisdr deleted the hashing_update branch June 29, 2022 19:34
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants