This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
708 - fix console warning in disable connections #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| key: connection_key, | ||
| name, | ||
| disabled: shouldDisable, | ||
| access: access_type, | ||
| connection_type, | ||
| }) | ||
| .unwrap() |
There was a problem hiding this comment.
Does the modal still close once the request finishes?
There was a problem hiding this comment.
Yup, it still closes automatically once the request completes
There was a problem hiding this comment.
That's great. So was the issue was calling the onClose function after the modal had closed?
There was a problem hiding this comment.
bravo @eastandwestwind! good find
There was a problem hiding this comment.
yeah, that onClose was the issue. I suspect something to do with the component possibly being unmounted by the time onClose is called
pattisdr
approved these changes
Jun 28, 2022
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
* removes unneeded code in disable connection
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix console warning in disable connections
Changes
Checklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #708