Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

513 - [Admin UI] Update Subject Request status filter to be a multise… #764

Merged
merged 13 commits into from
Jul 6, 2022
Merged

513 - [Admin UI] Update Subject Request status filter to be a multise… #764

merged 13 commits into from
Jul 6, 2022

Conversation

chriscalhoun1974
Copy link
Contributor

@chriscalhoun1974 chriscalhoun1974 commented Jun 30, 2022

…lect dropdown

Purpose

[Admin UI] Update Subject Request status filter to be a multiselect dropdown
#513

Changes

  • [Admin UI] Update Subject Request status filter to be a multiselect dropdown

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #513

Screen Shot 2022-06-30 at 9 16 36 AM
Screen Shot 2022-06-30 at 9 17 01 AM
Screen Shot 2022-06-30 at 9 17 24 AM

@chriscalhoun1974 chriscalhoun1974 marked this pull request as ready for review June 30, 2022 13:59
@chriscalhoun1974
Copy link
Contributor Author

If you run the Admin UI locally and select more than one Status from the filter dropdown, you will receive a HTTP 422 Unprocessable Entity exception in Chrome Dev Tools. This branch has a DEV dependency on another JIRA story:

#660

Currently, I am working on the above JIRA story in another branch. However, I wanted others to go ahead on give me any feedback on this given PR. Thank you!

Screen Shot 2022-06-30 at 5 43 52 PM

@chriscalhoun1974
Copy link
Contributor Author

I have merged the latest from main which contained the BE functionality needed. Ready for code review now.

Copy link
Contributor

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great @chriscalhoun1974, just need the changelog update.

@pattisdr pattisdr merged commit c5c3084 into ethyca:main Jul 6, 2022
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
#764)

Co-authored-by: Christopher Calhoun <chris@ethyca.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Admin UI] Update Subject Request status filter to be a multiselect dropdown
3 participants