Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

[Admin UI] Change Login Page Wording #774

Merged
merged 6 commits into from
Jul 8, 2022
Merged

Conversation

RobertKeyser
Copy link
Contributor

@RobertKeyser RobertKeyser commented Jul 1, 2022

Purpose

Changing the wording of the admin ui page to improve grammatical accuracy. Also fixed a typo on the subject request details page and on the datastore connections page. These are purely visual changes.

Evidence in support of the change on UI page

Changes

  • Instead of "sign into your account", I've changed it to "sign in to your account".
  • "indentities" --> "identities"
  • "Sass" --> "SaaS"

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #

@RobertKeyser RobertKeyser changed the title [Admin-UI] Change Login Page Wording [Admin-UI] Fix Typos and Change Admin Page Wording Jul 1, 2022
@RobertKeyser RobertKeyser changed the title [Admin-UI] Fix Typos and Change Admin Page Wording [Admin UI] Change Login Page Wording Jul 1, 2022
@seanpreston seanpreston self-assigned this Jul 7, 2022
Copy link
Contributor

@seanpreston seanpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the 🦅 👀 @conceptualshark

@seanpreston seanpreston merged commit cf3cbaf into main Jul 8, 2022
@seanpreston seanpreston deleted the rk-adminui-wording branch July 8, 2022 09:41
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
* sign in to instead of sign into

Changing the wording of the admin ui page to improve grammatical accuracy.

* fides admin-ui wording changelog

* added link to pr

* fix typo on subject identities

* updated changelog

* typo
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants