Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Fixing check-migration command #806

Merged
merged 3 commits into from
Jul 6, 2022

Conversation

galvana
Copy link
Collaborator

@galvana galvana commented Jul 6, 2022

Purpose

To fix check-migration Make command

Changes

  • Importing Fidesops base instead of Fideslib base so the Alembic functions use the correct metadata to compare against the database.

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #792

@galvana galvana linked an issue Jul 6, 2022 that may be closed by this pull request
@galvana galvana added the run unsafe ci checks Triggers running of unsafe CI checks label Jul 6, 2022
@galvana galvana changed the title Importing Fidesops base instead of Fideslib base for Alembic functions Fixing check-migration command Jul 6, 2022
@galvana galvana added run unsafe ci checks Triggers running of unsafe CI checks and removed run unsafe ci checks Triggers running of unsafe CI checks labels Jul 6, 2022
@galvana galvana marked this pull request as ready for review July 6, 2022 00:51
@galvana galvana requested a review from seanpreston July 6, 2022 00:51
@sanders41
Copy link
Contributor

Thanks @galvana! I have tried so many things trying to fix this test, and would never have thought to try this. The failing unsafe check doesn't look to me like it is related to this PR. Do you think it would pass if we restart it?

@galvana galvana added run unsafe ci checks Triggers running of unsafe CI checks and removed run unsafe ci checks Triggers running of unsafe CI checks labels Jul 6, 2022
@galvana
Copy link
Collaborator Author

galvana commented Jul 6, 2022

Hey @sanders41, you're welcome! It looks like the recent failures were caused by some timing issues so we should be good to go!

@galvana galvana requested review from sanders41 and seanpreston and removed request for seanpreston July 6, 2022 01:50
@galvana galvana merged commit d9b8eae into main Jul 6, 2022
@galvana galvana deleted the 792-fix-failing-check-migrations-ci-check branch July 6, 2022 01:51
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
run unsafe ci checks Triggers running of unsafe CI checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failing check-migrations CI check
2 participants