Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Fix issue requiring separate install of snowflake-connector-python #807

Merged
merged 2 commits into from
Jul 6, 2022

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Jul 6, 2022

Purpose

Fixes the issue requiring snowflake-connector-python to be installed in docker with --no-use-pep517, also removing the need to install cryptography separately in the Dockerfile.

Changes

  • Install python3-wheel in the Dockerfile
  • Remove the step to install cryptography in the Dockerfile
  • Remove the step to install snowflake-connector-python in the Dockerfile

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #744

@seanpreston seanpreston merged commit db326b3 into main Jul 6, 2022
@seanpreston seanpreston deleted the docker-dependencies branch July 6, 2022 07:28
sanders41 added a commit that referenced this pull request Sep 22, 2022
)

* Fix issue requiring separate install of snowflake-connector-python

* Update CHANGELOG

Co-authored-by: Paul Sanders <pau@ethyca.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move dependencies declared in Dockerfile to more "proper" location
2 participants