Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Update Celery config defaults #808

Merged
merged 9 commits into from
Jul 7, 2022
Merged

Update Celery config defaults #808

merged 9 commits into from
Jul 7, 2022

Conversation

seanpreston
Copy link
Contributor

Purpose

Changes the default Celery implementation settings to default to the Redis cache.

Changes

  • Adds a redis_connection_url that can be manually specified
  • Set result_backend to redis_connection_url if no celery_result_backend is supplied
  • Set broker_url to redis_connection_url if no celery_broker_url is supplied

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #771

@seanpreston seanpreston changed the title update celery config defaults, set to redis settings if none provided Update Celery config defaults Jul 6, 2022
sanders41
sanders41 reviewed Jul 6, 2022
View reviewed changes
src/fidesops/core/config.py Show resolved Hide resolved
src/fidesops/core/config.py Outdated Show resolved Hide resolved
@seanpreston seanpreston mentioned this pull request Jul 6, 2022
Merged
10 tasks
@sanders41 sanders41 merged commit 8ed1c94 into main Jul 7, 2022
@sanders41 sanders41 deleted the 771-celery-config branch July 7, 2022 15:35
sanders41 pushed a commit that referenced this pull request Sep 22, 2022
Update Celery config defaults (#808)
6ac8843 
* update celery config defaults, set to redis settings if none provided

* rename REDIS_CONNECTION_URL to CONNECTION_URL

* add var to config reference

* make DB index optional, use f'string

* adds support for redis USER

* add default for db_index in format string

* set correct default for USER
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sanders41 sanders41 sanders41 approved these changes

Assignees

@sanders41 sanders41

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make Celery connection defaults more sane
2 participants
@seanpreston @sanders41