Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Bump fideslib to handle base64 encoded password #820

Merged
merged 6 commits into from
Jul 7, 2022
Merged

Bump fideslib to handle base64 encoded password #820

merged 6 commits into from
Jul 7, 2022

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Jul 7, 2022 •
edited

Purpose

Bumps fideslib to 2.2.1 in order to handle base64 encoded passwords.

Changes

  • Bump fideslib to 2.2.1
  • Update tests to encode password.
  • Replace UserPasswordUpdate with the version from fideslib

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #809
Fixes #803

@sanders41 sanders41 changed the title Handle hashed password Bump fideslib to handle base64 encoded password Jul 7, 2022
@eastandwestwind eastandwestwind merged commit 1989518 into main Jul 7, 2022
@eastandwestwind eastandwestwind deleted the password branch July 7, 2022 18:40
sanders41 added a commit that referenced this pull request Sep 22, 2022
@sanders41
Bump fideslib to handle base64 encoded password (#820)
96fd803 
* Handle hashed password

* Update CHANGELOG

* Fix failing test and use UserPasswordReset schema from fideslib

* Restore fidesops.toml

Co-authored-by: Paul Sanders <pau@ethyca.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eastandwestwind eastandwestwind eastandwestwind approved these changes

Assignees

@eastandwestwind eastandwestwind

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fidesops Can't Login: Base64 Regression [Maintenance] Cleanup after user models migration to fideslib
2 participants
@sanders41 @eastandwestwind