This repository has been archived by the owner on Nov 30, 2022. It is now read-only.
671 - [Datastore Management] Include Icon with datastore connection (FE) #845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For the additional BE story to render the given SASS connection type such as Hubspot, please reference the following: Backend for SaaS Connector Logos#828 NOTE: I have accounted for an optional sass_config.type property to be added to the |
Resolved import statement issues
Resolved import statement issues
Resolved import statement issues
Resolved import statement issues
1. Updated connector svg images 2. Added default style to Spinner component
Deleted unnecessary file
Updated MySQL and Outreach .svg files
eastandwestwind
suggested changes
Jul 12, 2022
There was a problem hiding this comment.
Nice work @chriscalhoun1974 , mostly some syntax / spelling things to address.
clients/admin-ui/src/features/datastore-connections/ConnectionGridItem.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/datastore-connections/ConnectionGridItem.tsx
Show resolved
Hide resolved
clients/admin-ui/src/features/datastore-connections/ConnectionGridItem.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/datastore-connections/constants.ts
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/datastore-connections/constants.ts
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/datastore-connections/ConnectionGridItem.tsx
Show resolved
Hide resolved
|
@eastandwestwind I have updated the PR with your feedback. Let me know if I may have missed anything. Thanks again for looking at this. Much appreciated. |
clients/admin-ui/src/features/datastore-connections/ConnectionGridItem.tsx
Outdated
Show resolved
Hide resolved
eastandwestwind
approved these changes
Jul 13, 2022
sanders41
pushed a commit
that referenced
this pull request
Sep 22, 2022
…FE) (#845) * 671 - [Datastore Management] Include Icon with datastore connection (FE) * 671 - [Datastore Management] Include Icon with datastore connection (FE) * Updated CHANGELOG.md file * 671 - [Datastore Management] Include Icon with datastore connection (FE) Resolved import statement issues * 671 - [Datastore Management] Include Icon with datastore connection (FE) Resolved import statement issues * 671 - [Datastore Management] Include Icon with datastore connection (FE) Resolved import statement issues * 671 - [Datastore Management] Include Icon with datastore connection (FE) Resolved import statement issues * 671 - [Datastore Management] Include Icon with datastore connection (FE) 1. Updated connector svg images 2. Added default style to Spinner component * 671 - [Datastore Management] Include Icon with datastore connection (FE) Deleted unnecessary file * 671 - [Datastore Management] Include Icon with datastore connection (FE) Updated MySQL and Outreach .svg files * Renamed connectors folder to connector-logos * Resolved misspelling error in import statement * Code review feedback * Code review feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Changes
Checklist
CHANGELOG.mdfileCHANGELOG.mdfile is being appended toUnreleasedsection in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checkslabel has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #671