Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Reduce docker image size #846

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Reduce docker image size #846

merged 2 commits into from
Jul 11, 2022

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Jul 11, 2022

Purpose

By adding more unneeded files to the .dockerignore file and some slight tweaks to the Dockerfile I was able to reduce the images size from 1.92GB to 1.21GB, a 37% reduction.

I was hoping this would also speed up the builds, and it did, but only from 11 minutes down to 10 minutes and 90 seconds (1.5% reduction) so nothing noticable.

Changes

  • Added files to the .dockerignore file
  • Added --no-cache-dir to the pip install sections since pip's cache will never be used in docker so we don't need to store the cache files
  • Combine some pip install sections to try to improve cache speed

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #

@TheAndrewJackson TheAndrewJackson merged commit e0587b1 into main Jul 11, 2022
@TheAndrewJackson TheAndrewJackson deleted the dockerignore branch July 11, 2022 15:27
sanders41 added a commit that referenced this pull request Sep 22, 2022
* Reduce docker image size

* Update CHANGELOG

Co-authored-by: Paul Sanders <pau@ethyca.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants