Skip to content
This repository has been archived by the owner on Nov 30, 2022. It is now read-only.

Fix create_test_data #862

Merged
merged 4 commits into from
Jul 13, 2022
Merged

Fix create_test_data #862

merged 4 commits into from
Jul 13, 2022

Conversation

sanders41
Copy link
Contributor

@sanders41 sanders41 commented Jul 12, 2022 •
edited

Purpose

Fix the error when running make test-data

Changes

  • Remove the get_db_session and ClientDetail imports from fidesops.

Checklist

  • Update CHANGELOG.md file
    • Merge in main so the most recent CHANGELOG.md file is being appended to
    • Add description within the Unreleased section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.
    • Add a link to this PR at the end of the description with the PR number as the text. example: #1
  • Applicable documentation updated (guides, quickstart, postman collections, tutorial, fidesdemo, database diagram.
  • If docs updated (select one):
    • documentation complete, or draft/outline provided (tag docs-team to complete/review on this branch)
    • documentation issue created (tag docs-team to complete issue separately)
  • Good unit test/integration test coverage
  • This PR contains a DB migration. If checked, the reviewer should confirm with the author that the down_revision correctly references the previous migration before merging
  • The Run Unsafe PR Checks label has been applied, and checks have passed, if this PR touches any external services

Ticket

Fixes #861

@seanpreston seanpreston requested review from pattisdr and removed request for pattisdr July 12, 2022 15:13
@seanpreston seanpreston self-assigned this Jul 12, 2022
seanpreston
seanpreston approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@seanpreston seanpreston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great spot @sanders41

@seanpreston seanpreston changed the title Fix create_test_data Fix create_test_data Jul 13, 2022
@seanpreston seanpreston merged commit c114673 into main Jul 13, 2022
@seanpreston seanpreston deleted the create-test-data branch July 13, 2022 11:48
sanders41 added a commit that referenced this pull request Sep 22, 2022
@sanders41
Fix create_test_data (#862)
25d62be 
* Fix create_test_data

* Update CHANGELOG

Co-authored-by: Paul Sanders <pau@ethyca.com>
Co-authored-by: Sean Preston <sean@ethyca.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@seanpreston seanpreston seanpreston approved these changes

Assignees

@seanpreston seanpreston

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error on running make test-data
2 participants
@sanders41 @seanpreston