Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed require_module for Django 1.9 #64

Closed
wants to merge 1 commit into from

Conversation

shelldweller
Copy link

Pull request for #63. Tested under Django 1.7 and later. Once merged, could you please upload a new release to PyPI?

@etianen
Copy link
Owner

etianen commented Feb 4, 2016

Oh, I just merged #62, but only because it was top of my inbox and appears to work.

Is there any compelling reason why the additional changes in this are an improvement? From what I can tell, using mark_safe is a little simpler in this context, since the template tag is so small.

Happy to reopen this and merge if there's a good reason to do so.

@shelldweller
Copy link
Author

I didn't see the other request when submitting mine. My patch has an updated test case that verifies actual template rendering, not just output of template tag. Without this change the old unit test gives a false positive when running under Django 1.9. And updated test case requires a change to settings.py to silence deprecation warning.

etianen added a commit that referenced this pull request Feb 15, 2016
@etianen
Copy link
Owner

etianen commented Feb 15, 2016

I've updated the master branch with your tests. A new release will be out momentarily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants