Skip to content

Commit

Permalink
Merge pull request #921 from tony/log-integrity-error
Browse files Browse the repository at this point in the history
`_safe_revert`: Add a `logging` statement for `IntegrityError`
  • Loading branch information
etianen committed Oct 2, 2022
2 parents 284dd51 + 7546b25 commit 9295e00
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions reversion/models.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from collections import defaultdict
from itertools import chain, groupby
import logging

import django
from django.apps import apps
Expand All @@ -22,13 +23,17 @@
_get_content_type, _get_options)


logger = logging.getLogger(__name__)


def _safe_revert(versions):
unreverted_versions = []
for version in versions:
try:
with transaction.atomic(using=version.db):
version.revert()
except (IntegrityError, ObjectDoesNotExist):
logger.warning('Could not revert to {version}', exc_info=True)
unreverted_versions.append(version)
if len(unreverted_versions) == len(versions):
raise RevertError(gettext("Could not save %(object_repr)s version - missing dependency.") % {
Expand Down

0 comments on commit 9295e00

Please sign in to comment.