Merge pull request #946 from etianen/revert-fix

Handling case of missing object in admin revert
etianen · Sep 19, 2023 · f84a31c · f84a31c
2 parents 3d95952 + b88a15c
commit f84a31c
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/reversion/admin.py b/reversion/admin.py
@@ -178,10 +178,14 @@ def _reversion_revisionform_view(self, request, version, template_name, extra_co
                         set_comment(_("Reverted to previous version, saved on %(datetime)s") % {
                             "datetime": localize(template_localtime(version.revision.date_created)),
                         })
-                    else:
+                    elif response.status_code == 200:
                         response.template_name = template_name  # Set the template name to the correct template.
                         response.render()  # Eagerly render the response, so it's using the latest version.
                         raise _RollBackRevisionView(response)  # Raise exception to undo the transaction and revision.
+                    else:
+                        raise RevertError(_("Could not load %(object_repr)s version - not found") % {
+                            "object_repr": self.object_repr,
+                        })
         except (RevertError, models.ProtectedError) as ex:
             opts = self.model._meta
             messages.error(request, force_str(ex))