GH actions: add check for missing migrations (and fix migrations) #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #959 and adds a GH action check via Django's
makemigrations --checkto prevent it happening again (you can see the failing check here).I also "fixed" the missing migration by just modifying the original migration instead of creating a new one (instead of #960) since this specific
Model.Metachange doesn't affect the SQL schema this should be safe to do and thus doesn't require users to run new migrations in the next release.There was also a missing migration in the test suite, I just created that since I didn't want to dig into that change too much and that migration wouldn't affect end users of this library.