Skip to content

Commit

Permalink
Don't depend on Action Pack from Railties
Browse files Browse the repository at this point in the history
In 8ff310a, the Railties gem was split
from the Rails gem so that you could depend on it and skip some
frameworks, e.g. replace Active Record with something else.

Since then, Rails evolved and the current approach is to always depend
on Rails, but skipped frameworks are not required from
config/application.rb.

When writing a Railtie for Active Record or Active Job for example, it's
weird that the plugin ends up depending on Action Pack even if it's not
used at all.
  • Loading branch information
etiennebarrie committed Sep 4, 2023
1 parent 42db7f3 commit 0f717ab
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 2 deletions.
1 change: 0 additions & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@ PATH
bundler (>= 1.15.0)
railties (= 7.1.0.alpha)
railties (7.1.0.alpha)
actionpack (= 7.1.0.alpha)
activesupport (= 7.1.0.alpha)
irb
rackup (>= 1.0.0)
Expand Down
1 change: 0 additions & 1 deletion railties/railties.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ Gem::Specification.new do |s|
# https://edgeguides.rubyonrails.org/security.html#dependency-management-and-cves

s.add_dependency "activesupport", version
s.add_dependency "actionpack", version

s.add_dependency "rackup", ">= 1.0.0"
s.add_dependency "rake", ">= 12.2"
Expand Down

0 comments on commit 0f717ab

Please sign in to comment.