Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception raised from circuited function should be propagated #7

Merged
merged 1 commit into from
May 22, 2021

Conversation

migibert
Copy link
Contributor

Hello,

Thanks for this amazing library that looks the most feature complete when looking for a circuit breaker in python.

I tried to use it in my project and noticed that when an exception is raised from a circuited function, it is not propagated to the caller.

I also used this PR to fix a bad behavior when using named arguments in circuited functions.

@etimberg
Copy link
Owner

Change looks good, thanks for sending it 😄 . I will merge this and fix the CI over the weekend as it will be a long weekend for me. I'll ping you once I've got it released to PyPI

@migibert
Copy link
Contributor Author

Great, thanks for the update!

@etimberg etimberg merged commit 8662748 into etimberg:master May 22, 2021
@etimberg
Copy link
Owner

This is out on PyPI as v0.3.0

@migibert
Copy link
Contributor Author

Thanks for your reactivity, it really helps me with my current project 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants