Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix defaulted constructed SEQUENCE component initialization #146

Merged
merged 1 commit into from
Dec 29, 2018

Conversation

etingof
Copy link
Owner

@etingof etingof commented Oct 18, 2018

When SEQUENCE has defaulted component of constructed type, recursively instantiate defaulted component and assign instantiated asn1 object to SEQUENCE field.

@codecov-io
Copy link

codecov-io commented Oct 18, 2018

Codecov Report

Merging #146 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #146      +/-   ##
==========================================
- Coverage   68.51%   68.49%   -0.03%     
==========================================
  Files          29       29              
  Lines        5095     5100       +5     
==========================================
+ Hits         3491     3493       +2     
- Misses       1604     1607       +3
Impacted Files Coverage Δ
pyasn1/type/univ.py 75.26% <100%> (-0.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7a502f...9a57cfc. Read the comment docs.

When SEQUENCE has defaulted component of constructed type,
recursively instantiate defaulted component and assign instantiated
asn1 object to SEQUENCE field.
@etingof etingof merged commit 7b6c498 into master Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants