Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable updating health checks #134

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

bronsh
Copy link

@bronsh bronsh commented Jul 19, 2016

We needed the ability to change the health-check function while program is running.

On current implementation, once you register the health-check function, you cannot change it any more.
It is stored in the dictionary, and even if you try to register a new function on the same name, it will not be registered, since there already exists another function registered on the same name (The "TryAdd" on the dictionary will return false, and nothing will happen)
For instance, If the check function is contained in some object, and the object is disposed or its reference is lost, you have no ability to control the health-check function any more.

For this purpose, I added two new features:

  1. There is a way to unregister just one check-function (by registration name), with no need to unregister all health checks
  2. If someone tries to register a new check-function under the same name, it will override the current check-function, and registration will succeed.

Commit by David Bronshtein <david.br@gigya-inc.com>
On branch: refs/heads/HealthCheck_Updating
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant