Switch to gopkg.in/yaml.v3 #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main reason to switch (apart from keeping dependencies up-to-date) is the default behaviour for line wrapping. In yaml.v2, the default was line wrapping after 80 characters. In yaml.v3, no line wrapping by default. For mirrorbits, line wrapping manifests itself in the `show` and `edit` commands. It's an issue, in the sense that it makes it difficult for scripts to interact with those commands, since long values might spread over several lines. For example, parsing the output of `mirrorbits show` with `grep` is error prone because of line wrapping. This commit bumps the build depencency gopkg.in/yaml from v2 to v3, thus disabling line wrapping in yaml output. Closes: etix#153
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main reason to switch (apart from keeping dependencies up-to-date) is the default behaviour for line wrapping. In yaml.v2, the default was line wrapping after 80 characters. In yaml.v3, no line wrapping by default.
For mirrorbits, line wrapping manifests itself in the
showandeditcommands. It's an issue, in the sense that it makes it difficult for scripts to interact with those commands, since long values might spread over several lines. For example, parsing the output ofmirrorbits showwithgrepis error prone because of line wrapping.This commit bumps the build depencency gopkg.in/yaml from v2 to v3, thus disabling line wrapping in yaml output.
Closes: #153