Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pb_sv_getss alternative #1942

Closed
x0rnn opened this issue Apr 12, 2022 · 6 comments
Closed

Add pb_sv_getss alternative #1942

x0rnn opened this issue Apr 12, 2022 · 6 comments
Labels
cat: general Category engine (client/server) 💡 Feature New feature or request P3: Normal Priority 3

Comments

@x0rnn
Copy link
Contributor

x0rnn commented Apr 12, 2022

"PB_SV_GetSs [player_name_or_slot#]
Sends a request to all applicable connected players asking for a screen shot to be captured and sent to the PB Server"

@rafal1137 rafal1137 added the ❌ Invalid This doesn't seem right label Apr 12, 2022
@rafal1137
Copy link
Member

Do not you know that PB does not support ET at all anymore ?
Thus sending screenshots to PB Servers never gonna happen.

Marking this as invalid and closing

@Aciz
Copy link
Member

Aciz commented Apr 12, 2022

He's talking about ALTERNATIVE to this, ofc PB is and never will be supported.

@Aciz Aciz reopened this Apr 12, 2022
@Aciz Aciz removed the ❌ Invalid This doesn't seem right label Apr 12, 2022
@x0rnn
Copy link
Contributor Author

x0rnn commented Apr 12, 2022

Yea, I didn't mean sending it to a PB server, but saved in a directory on the gameserver...

@HeDo88TH
Copy link
Contributor

This could be a good step forward in cheat detection. But I wonder if we should impose some sort of "client certification" in order to connect to the game servers. That way someone could just edit the source code, recompile it, and play with a rogue client. I don't know if anyone is already doing this, but this is a threat that we absolutely need to consider.
We can also add all pb functionality within the legacy client, but that won't stop any determined cheaters from doing what I just pointed out.

@x0rnn
Copy link
Contributor Author

x0rnn commented Apr 21, 2022

Yea, I was thinking, if this is open source, anyone could just modify the client so it would send clean screenshots I suppose...

@ensiform
Copy link
Contributor

This could be a good step forward in cheat detection. But I wonder if we should impose some sort of "client certification" in order to connect to the game servers. That way someone could just edit the source code, recompile it, and play with a rogue client. I don't know if anyone is already doing this, but this is a threat that we absolutely need to consider.
We can also add all pb functionality within the legacy client, but that won't stop any determined cheaters from doing what I just pointed out.

I think the best you can hope for is the server mod has authentication for client check for competitive servers but not enabled on public's. Which given enough crafty coding could still be circumvented but you'd keep the majority out. Such is the nature of open source/copyleft engine. You can't really include any closed parts. Also pretty sure GPL v3 closed some of the license loopholes which were doable with GPL v2 (Q3).

There is very little benefit to doing anticheat in such conditions because you'll only be stopping people who aren't determined to cheat.

Also, adding more features that lock players behind one engine is unfriendly to the spirit of open source in general imo.

@Aranud Aranud added cat: general Category engine (client/server) P3: Normal Priority 3 💡 Feature New feature or request labels Apr 29, 2022
@Aranud Aranud modified the milestones: ALL, Future Apr 29, 2022
@x0rnn x0rnn closed this as not planned Won't fix, can't repro, duplicate, stale Feb 13, 2024
@Aranud Aranud removed this from the Future milestone Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: general Category engine (client/server) 💡 Feature New feature or request P3: Normal Priority 3
Projects
None yet
Development

No branches or pull requests

6 participants