Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default value of sv_timeout to 40 seconds and create a new timeout cvar for clients not in game #29

Closed
ETLegacyTeam opened this issue Mar 5, 2020 · 5 comments
Labels
cat: server Category engine (server) 💡 Feature New feature or request P3: Normal Priority 3
Milestone

Comments

@ETLegacyTeam
Copy link
Member

ETLegacyTeam commented Mar 5, 2020

Author: @IR4T4 (IR4T4)
Date: 2012-04-22
Redmine Issue: 29, https://dev.etlegacy.com/issues/29


As mentioned in the chat - decrease the default value of sv_timeout to 15 seconds (15). 4 min (240) is a long time! In the past this was done by PB before sv_timeout got active. There are several reasons to use a short period of time here (f.e. w/o additional code in the mod clients stay 'connected' after a client crash)


Related commit(s):
c471628 - set sv_timeout to 15 seconds, fixes 29
dc57d5c - better value for sv_timeout refs 29
ed2f70a - extended time out message refs 29
69561e8 - new cvar sv_dl_timeout - timeout value for clients..
8d65c9f - sv_timeout default value changed to 40 refs 29
2862f09 - comment update see refs 29

@ETLegacyTeam ETLegacyTeam added cat: server Category engine (server) 💡 Feature New feature or request Fixed P3: Normal Priority 3 labels Mar 5, 2020
@ETLegacyTeam ETLegacyTeam added this to the 2.70rc1 milestone Mar 5, 2020
@ETLegacyTeam
Copy link
Member Author

From: @IR4T4 (IR4T4)
Date: 2012-07-26T17:31:21Z


Reopened. This is an important task to improve ET ...

We have had issues while client is downloading pk3s. In game the setting of 15 seconds works perfectly so we should just add and implement another timeout var for the download part -> sv_timeout_dl or sv_dl_timeout

For downloading clients this var is used to define our timeout.

@ETLegacyTeam
Copy link
Member Author

From: @JanSimek (Radegast)
Date: 2012-07-26T19:08:45Z


Agreed, good solution.

@ETLegacyTeam
Copy link
Member Author

From: @IR4T4 (IR4T4)
Date: 2012-07-26T20:42:59Z


sv_dl_timeout introduced.

@ETLegacyTeam
Copy link
Member Author

From: @JanSimek (Radegast)
Date: 2012-08-15T20:37:28Z


As user:morsik found out, the value @sv_timeout@ is now too low and game time-outs because client is @CS_ACTIVE@ when using @/vid_restart@ or @/snd_restart@

@sv_main.c@:

int      droppoint    = svs.time - 1000 * sv_timeout->integer;   // default 15

if (cl->state == CS_ACTIVE && cl->lastPacketTime < droppoint)
...
</code>

@ETLegacyTeam
Copy link
Member Author

From: @IR4T4 (IR4T4)
Date: 2012-08-15T20:53:41Z


It's odd CS_ACTIVE is used while vid_restart. The default value has been changed to 40. This should even catch poor CPU clients.

-> works for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cat: server Category engine (server) 💡 Feature New feature or request P3: Normal Priority 3
Projects
None yet
Development

No branches or pull requests

1 participant