Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderer2: fix 'fogvars' fog / fog issues #553

Open
ETLegacyTeam opened this issue Mar 5, 2020 · 10 comments
Open

renderer2: fix 'fogvars' fog / fog issues #553

ETLegacyTeam opened this issue Mar 5, 2020 · 10 comments
Labels
🐞 Bug Something isn't working cat: client Category engine (client, renderer, sdl) P3: Normal Priority 3
Milestone

Comments

@ETLegacyTeam
Copy link
Member

ETLegacyTeam commented Mar 5, 2020

Author: @IR4T4 (IR4T4)
Date: 2014-08-02
Redmine Issue: 553, https://dev.etlegacy.com/issues/553


As the title says - fog doesn't work.

Affected maps (f.e.):

  • stalingrad
  • baserace

Actually q3 and ET use different foq code! Vanilla ET/r1 don't use the fogTable. This has been removed with http://dev.etlegacy.com/projects/etlegacy/repository/revisions/4e5eba5b3977847342143350f0603514a495d3b9

I did try to add the q3 style for r1 but I wasn't able to adjust the density of foq to 'known ET' style fog. See attached images. Unfortunately I didn't do a screeny of a wide sight - the range of view is very short (max 1024 game units).


Related commit(s):
f0633a9 - renderer2: q3/ET fog enabled refs 553
d6e4020 - renderer2: read all available submodel data from b..

@ETLegacyTeam ETLegacyTeam added 🐞 Bug Something isn't working cat: client Category engine (client, renderer, sdl) P3: Normal Priority 3 labels Mar 5, 2020
@ETLegacyTeam ETLegacyTeam added this to the renderer2 milestone Mar 5, 2020
@ETLegacyTeam
Copy link
Member Author

From: @jackeri (Jacker)
Date: 2014-08-06T07:24:12Z


This needs to be fixed with a custom glsl shader path, not a hard fix to do :)

@ETLegacyTeam
Copy link
Member Author

From: @thunderpwn (thunder)
Date: 2017-04-08T15:38:46Z


http://in2gpu.com/2014/07/22/create-fog-shader/

@ETLegacyTeam
Copy link
Member Author

From: @IR4T4 (IR4T4)
Date: 2017-09-29T15:43:00Z


I've had a look at this again and figured out why q3/ET fog wasn't visible in general. This has been fixed.

{FIXME}

  • Make fog more foggy. Compared to r1 it's currently more a cut at the horizon.
  • Rework SetFarClip() - see buildings (f.e. baserace) on different distances. It doesn't look natural.

@ETLegacyTeam
Copy link
Member Author

@ETLegacyTeam
Copy link
Member Author

From: @IR4T4 (IR4T4)
Date: 2018-02-11T15:55:21Z


Re-opened. Fog needs some optimizations see baserace or radar.
Compared to r2 It looks a bit too intensive and the sky on radar isn't visible.

@ETLegacyTeam
Copy link
Member Author

From: @IR4T4 (IR4T4)
Date: 2018-03-20T09:42:31Z


{FIXME}
Maps with fogvars set don't display this fog. Example: https://www.wolffiles.de/index.php?filebase&fid=4901

@ETLegacyTeam
Copy link
Member Author

From: @IR4T4 (IR4T4)
Date: 2018-03-24T13:36:05Z


Fog has been reworked (should be fine for a release) but it's still WIP.

@ETLegacyTeam
Copy link
Member Author

From: @IR4T4 (IR4T4)
Date: 2018-03-27T08:55:48Z


{FIXME}

  • inspect global world fog using static density?

@ETLegacyTeam
Copy link
Member Author

From: @thunderpwn (thunder)
Date: 2019-09-29T12:24:39Z


still need to get both fogs on the maps loaded with shader only

@ETLegacyTeam
Copy link
Member Author

From: @thunderpwn (thunder)
Date: 2019-10-06T11:19:10Z


cant fix that maps issues atm..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug Something isn't working cat: client Category engine (client, renderer, sdl) P3: Normal Priority 3
Projects
None yet
Development

No branches or pull requests

1 participant